feat(spans): enforce max segment bytes during ingestion#112561
Merged
feat(spans): enforce max segment bytes during ingestion#112561
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6fff2a5. Configure here.
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
Refs STREAM-859 We want to able to skip merging further subsegments into the set but we don't want to drop data. So naturally, a subsegment not being merged into its set have to become its own separate segment. - Adds the `spans.buffer.enforce-segment-size` option to force segment size limit of `max-segment-bytes`. - When the option is enabled: - The Lua script checks cumulative ingested bytes of the target set to decide whether to merge or not. - Writes each subsegment's payloads to a separate key determined by a random salt. This is to prevent dropping overflow subsegments when we decide not to merge them into the target set. Each subsegment not being merged will become its own separate segment, and we add a new key in the queue based on the salt value above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs STREAM-859
We want to able to skip merging further subsegments into the set but we don't want to drop data. So naturally, a subsegment not being merged into its set have to become its own separate segment.
spans.buffer.enforce-segment-sizeoption to force segment size limit ofmax-segment-bytes.